On Sat, Nov 7, 2009 at 12:14 PM, Jonathan Matthew <jonat...@d14n.org> wrote:
> Seems to be working fine now. To save some effort, here's a suitable > bug to attach this patch to: > https://bugzilla.gnome.org/show_bug.cgi?id=520046 > Thanks, attached the patch to the bug report. > I'm not sure it really buys you anything - transcoding to /tmp, then > checking if the resulting file will fit on the device is much the same > as transcoding onto the device, then deleting the file if you run out > of space, except there's more i/o and you don't find out that it's a > problem until you've transcoded the whole track. Sure this works. As you say the only advantage is that less i/o occurs on the device (in case the file is too large in the end). It might also be that transcoding to /tmp and copying the complete track afterwards is faster than transcoding directly to the device (last time I checked, appending wasn't very fast for flash drives) and also less i/o is better especially for cheap flash chips but this might be anecdotic (this whole situation happens only when the device is full). As far as the gui is concerned it would be nice to have an error entry on the side bar, below the corresponding device (like an rb-import-errors-source) rather than a dialog. Best, -- Kim _______________________________________________ rhythmbox-devel mailing list rhythmbox-devel@gnome.org http://mail.gnome.org/mailman/listinfo/rhythmbox-devel
