Hi there,
I'm currently trying to fix rhythmbox because it crashes when my
creative Zen touch (MTP device) is plugged in.
Although I'm not done, I think I've found a little bug in mpid-device.c
that may explain some crashes (git patch joined).
FYI the configuration I am working on is :
- Karmic beta on virtual box (not OSE to have USB support)
- Rhythmbox from the git repo. compiled with gudev
By the way I have some questions :
Is mtp plugins still required with gudev ?
With gudev option there are still calls to libmtp taking place (inside
rhythmbox), if I'm not wrong it shouldn't happen ?
François
>From 87daac7e62b709b3ec9b2e6334d7a8391c2b5e7c Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Fran=C3=A7ois?= <franc...@test-karmic.(none)>
Date: Mon, 19 Oct 2009 19:29:00 +0200
Subject: [PATCH] fix call to g_free
---
lib/libmediaplayerid/mpid-device.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/lib/libmediaplayerid/mpid-device.c b/lib/libmediaplayerid/mpid-device.c
index 31bc8f3..db3d1f8 100644
--- a/lib/libmediaplayerid/mpid-device.c
+++ b/lib/libmediaplayerid/mpid-device.c
@@ -149,7 +149,7 @@ mpid_device_get_device_path (MPIDDevice *device)
g_free (mount_path);
return device_path;
}
- g_free (mount_path);
+ g_free (mount);
/* it's not a mount point, so check if it's the path to a mounted device */
mounts = g_unix_mounts_get (NULL);
@@ -163,6 +163,7 @@ mpid_device_get_device_path (MPIDDevice *device)
g_unix_mount_free (mount);
}
g_list_free (mounts);
+ g_free(mount_path);
if (device_path == NULL) {
mpid_debug ("unable to find device path for mount point %s\n", device->input_path);
--
1.6.3.3
_______________________________________________
rhythmbox-devel mailing list
rhythmbox-devel@gnome.org
http://mail.gnome.org/mailman/listinfo/rhythmbox-devel
