On Sat, Oct 18, 2008 at 12:31:41PM +0530, Arun Chaganty wrote:
> Hey,
> I just did a grep on the rhythmbox code to check for gnome-vfs-ness:
>
> [EMAIL PROTECTED] rhythmbox]$ grep -c --include=*.{c,cpp,h,py} -r
> "(gnome_vfs)|(gnomevfs)" . | awk "/.*:[1-9][0-9]*/"
> ./plugins/rb/Loader.py:3
> ./plugins/coherence/upnp_coherence/__init__.py:2
> ./plugins/artdisplay/artdisplay/LocalCoverArtSearch.py:10
> ./plugins/jamendo/jamendo/JamendoConfigureDialog.py:1
> ./plugins/jamendo/jamendo/JamendoSource.py:29
> ./plugins/magnatune/magnatune/MagnatuneSource.py:49
> ./lib/rb-debug.c:1
> ./lib/rb-util.c:1
>
> (the last two belong in comments)
>
> We are planning to have a GIO porting day / whatchamacallit at
> foss.in/2008 [1]. I'd love have some feedback, suggestions, etc.
I've been putting off porting the python plugins to use gio, mostly
because pygobject's gio bindings only recently got to the point where it
would be possible. Not that that should stop anyone else who wants to work
on it, of course.
The magnatune and jamendo plugins have a fair bit of commonish code for
downloading catalog files. Rather than rewriting it twice, it'd be a
much better idea to add a common method (like the rb.Loader thing) to do
this. It might be worth doing the same for the magnatune downloader
code, but we've only got one plugin that needs that at the moment.
_______________________________________________
rhythmbox-devel mailing list
rhythmbox-devel@gnome.org
http://mail.gnome.org/mailman/listinfo/rhythmbox-devel
