GitHub user dbtsai opened a pull request:
https://github.com/apache/spark/pull/3735
[SPARK-4887][MLlib] Fix a bad unittest in LogisticRegressionSuite
The original test doesn't make sense since if you step in, the lossSum is
already NaN,
and the coefficients are diverging. That's because the step size is too
large for SGD,
so it doesn't work.
The correct behavior is that you should get smaller coefficients than the
one
without regularization. Comparing the values using 20000.0 relative error
doesn't
make sense as well.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AlpineNow/spark mlortestfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/3735.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3735
----
commit b1a3c422251e74301a7bee30ccaf4007ee78ba3d
Author: DB Tsai <[email protected]>
Date: 2014-12-18T19:40:46Z
first commit
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
