Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3696#discussion_r21844424
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/ExecutorRunnable.scala ---
@@ -50,11 +51,13 @@ class ExecutorRunnable(
executorCores: Int,
appId: String,
securityMgr: SecurityManager)
- extends Runnable with ExecutorRunnableUtil with Logging {
+ extends Runnable with Logging {
+
+ lazy val env = prepareEnvironment
var rpc: YarnRPC = YarnRPC.create(conf)
var nmClient: NMClient = _
- val sparkConf = spConf
+ val sparkConf: SparkConf = spConf
--- End diff --
Adding the type here is not really necessary (although it makes things more
consistent). But I'd suggest just removing this variable altogether, and rename
the constructor parameter instead).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
