Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/3442#discussion_r21129847
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala ---
@@ -193,4 +193,70 @@ class StatisticsSuite extends QueryTest with
BeforeAndAfterAll {
)
}
+ test("auto converts to broadcast left semi join, by size estimate of a
relation") {
+ def mkTest(
+ before: () => Unit,
+ after: () => Unit,
+ query: String,
+ expectedAnswer: Seq[Any],
+ ct: ClassTag[_]) = {
--- End diff --
Only indent arguments 4 spaces. Also, this function seems like overkill
given that it is only called once and the first two arguments are always no-ops.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
