Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/2524#discussion_r20911221
--- Diff: core/src/main/scala/org/apache/spark/Accumulators.scala ---
@@ -252,10 +254,9 @@ private object Accumulators {
val localAccums = Map[Thread, Map[Long, Accumulable[_, _]]]()
var lastId: Long = 0
- def newId: Long = synchronized {
- lastId += 1
- lastId
- }
+ private val nextAccumID = new AtomicLong(0)
+
+ def newId: Long = nextAccumID.getAndIncrement
--- End diff --
Nit: this should be called `newId()` since it has side-effects (I know it
wasn't called that before but might as well fix it)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
