Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/3120#discussion_r20829599
--- Diff: core/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala ---
@@ -252,7 +258,7 @@ class HadoopRDD[K, V](
&& bytesReadCallback.isDefined) {
recordsSinceMetricsUpdate = 0
val bytesReadFn = bytesReadCallback.get
- inputMetrics.bytesRead = bytesReadFn()
+ inputMetrics.bytesRead = bytesReadFn() + bytesReadAtStart
--- End diff --
Yeah that makes sense. The original proposal was just trying to isolate
this logic to HadoopRDD and simplify the input metrics interface. However,
given the interfaces exposed by Hadoop I don't think it's very easy to do that
so we'll have to leak this into the general way that input metrics are computed
(and use callbacks).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
