Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/3109#discussion_r20389712
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -262,7 +262,7 @@ object NullPropagation extends Rule[LogicalPlan] {
*/
object ConstantFolding extends Rule[LogicalPlan] {
def apply(plan: LogicalPlan): LogicalPlan = plan transform {
- case q: LogicalPlan => q transformExpressionsDown {
+ case q: LogicalPlan => q transformExpressionsUp {
--- End diff --
Why this change? It seem like this is strictly less efficient because it
will call evaluate for each subtree, constructing literals each time instead of
doing the evaluation in a single pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
