Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/3114#discussion_r20051871
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala ---
@@ -254,46 +255,59 @@ private[hive] trait HiveInspectors {
}
def toInspector(expr: Expression): ObjectInspector = expr match {
- case Literal(value: String, StringType) =>
- HiveShim.getPrimitiveWritableConstantObjectInspector(value)
- case Literal(value: Int, IntegerType) =>
- HiveShim.getPrimitiveWritableConstantObjectInspector(value)
- case Literal(value: Double, DoubleType) =>
- HiveShim.getPrimitiveWritableConstantObjectInspector(value)
- case Literal(value: Boolean, BooleanType) =>
- HiveShim.getPrimitiveWritableConstantObjectInspector(value)
- case Literal(value: Long, LongType) =>
- HiveShim.getPrimitiveWritableConstantObjectInspector(value)
- case Literal(value: Float, FloatType) =>
- HiveShim.getPrimitiveWritableConstantObjectInspector(value)
- case Literal(value: Short, ShortType) =>
- HiveShim.getPrimitiveWritableConstantObjectInspector(value)
- case Literal(value: Byte, ByteType) =>
- HiveShim.getPrimitiveWritableConstantObjectInspector(value)
- case Literal(value: Array[Byte], BinaryType) =>
- HiveShim.getPrimitiveWritableConstantObjectInspector(value)
- case Literal(value: java.sql.Date, DateType) =>
- HiveShim.getPrimitiveWritableConstantObjectInspector(value)
- case Literal(value: java.sql.Timestamp, TimestampType) =>
- HiveShim.getPrimitiveWritableConstantObjectInspector(value)
- case Literal(value: BigDecimal, DecimalType()) =>
- HiveShim.getPrimitiveWritableConstantObjectInspector(value)
- case Literal(value: Decimal, DecimalType()) =>
-
HiveShim.getPrimitiveWritableConstantObjectInspector(value.toBigDecimal)
+ case Literal(value, StringType) =>
+
HiveShim.getPrimitiveWritableConstantObjectInspector(value.asInstanceOf[String])
+ case Literal(value, IntegerType) =>
+
HiveShim.getPrimitiveWritableConstantObjectInspector(value.asInstanceOf[Int])
+ case Literal(value, DoubleType) =>
+
HiveShim.getPrimitiveWritableConstantObjectInspector(value.asInstanceOf[Double])
+ case Literal(value, BooleanType) =>
+
HiveShim.getPrimitiveWritableConstantObjectInspector(value.asInstanceOf[Boolean])
+ case Literal(value, LongType) =>
+
HiveShim.getPrimitiveWritableConstantObjectInspector(value.asInstanceOf[Long])
+ case Literal(value, FloatType) =>
+
HiveShim.getPrimitiveWritableConstantObjectInspector(value.asInstanceOf[Float])
+ case Literal(value, ShortType) =>
+
HiveShim.getPrimitiveWritableConstantObjectInspector(value.asInstanceOf[Short])
+ case Literal(value, ByteType) =>
+
HiveShim.getPrimitiveWritableConstantObjectInspector(value.asInstanceOf[Byte])
+ case Literal(value, BinaryType) =>
+
HiveShim.getPrimitiveWritableConstantObjectInspector(value.asInstanceOf[Array[Byte]])
+ case Literal(value, DateType) =>
+
HiveShim.getPrimitiveWritableConstantObjectInspector(value.asInstanceOf[java.sql.Date])
+ case Literal(value, TimestampType) =>
+
HiveShim.getPrimitiveWritableConstantObjectInspector(value.asInstanceOf[java.sql.Timestamp])
+ case Literal(value, DecimalType()) =>
+ if (null == value) {
+ HiveShim.getPrimitiveWritableConstantObjectInspector(
+ null.asInstanceOf[BigDecimal])
+ } else {
+ HiveShim.getPrimitiveWritableConstantObjectInspector(
+ value.asInstanceOf[Decimal].toBigDecimal)
+ }
case Literal(_, NullType) =>
HiveShim.getPrimitiveNullWritableConstantObjectInspector
- case Literal(value: Seq[_], ArrayType(dt, _)) =>
--- End diff --
We don't bind a type here, just to keep consistent with pattern match
above, and it is also helpful in debugging, you know, sometimes we just
confused what type for catalyst array (`Array` or `Seq`), the `.asInstanceOf`
will be a strong check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
