Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3103#discussion_r19857551
  
    --- Diff: assembly/pom.xml ---
    @@ -148,6 +148,17 @@
                     </relocation>
                   </relocations>
                   <transformers>
    +                <transformer 
implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
    +                  <manifestEntries>
    +                    
<Implementation-Vendor>org.apache.spark</Implementation-Vendor>
    +                    
<Implementation-Title>spark-assembly</Implementation-Title>
    +                    
<Implementation-Version>1.2.0-SNAPSHOT</Implementation-Version>
    --- End diff --
    
    Can you use the project.version instead of hard-coding this? I don't think 
you need or want to specify all this stuff beyond maybe vendor and version. 
There is no "specification" here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to