Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2676#discussion_r19773950
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -661,7 +662,10 @@ class SparkContext(config: SparkConf) extends Logging {
           fClass: Class[F],
           kClass: Class[K],
           vClass: Class[V]): RDD[(K, V)] = {
    -    new NewHadoopRDD(this, fClass, kClass, vClass, conf)
    +    // Add necessary security credentials to the JobConf. Required to 
access secure HDFS.
    +    val jconf = new JobConf(conf)
    +    SparkHadoopUtil.get.addCredentials(jconf)
    +    new NewHadoopRDD(this, fClass, kClass, vClass, jconf)
    --- End diff --
    
    In `hadoopFile` we actually mutate the existing conf. Should we modify this 
one or that one to be more consistent? It does seem more sensible here to 
duplicate it and then modify the copy.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to