Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2867#issuecomment-61014358
I downloaded this and tried it out. It looks good to me, except for a few
minor usability things:
- I should be able to click on either the checkbox _or the checkbox label_
to expand / hide a metric. I'm pretty sure that there's some standard HTML way
to group labels and input elements together so that clicking the label focuses
or toggles the field. The larger click target makes this easier to use / more
accessible.
- I'd place the arrow next to "Show additional metrics" inside of the link
/ header so that it's also clickable.
These are really minor nitpicks, though, although the first one could make
a big usability difference for users who have trouble clicking small things.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
