Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2940#discussion_r19498805
  
    --- Diff: 
streaming/src/main/scala/org/apache/spark/streaming/receiver/ReceivedBlockHandler.scala
 ---
    @@ -0,0 +1,144 @@
    +package org.apache.spark.streaming.receiver
    +
    +import java.nio.ByteBuffer
    +
    +import scala.collection.mutable.ArrayBuffer
    +import scala.concurrent.{Await, ExecutionContext, Future}
    +import scala.concurrent.duration._
    +import scala.language.{existentials, postfixOps}
    +
    +import WriteAheadLogBasedBlockHandler._
    +import org.apache.hadoop.conf.Configuration
    +import org.apache.hadoop.fs.Path
    +import org.apache.spark.{SparkException, Logging, SparkConf}
    +import org.apache.spark.storage.{BlockManager, StorageLevel, StreamBlockId}
    +import org.apache.spark.streaming.util.{Clock, SystemClock, 
WriteAheadLogManager}
    +import org.apache.spark.util.Utils
    +
    +private[streaming] sealed trait ReceivedBlock
    +private[streaming] case class ArrayBufferBlock(arrayBuffer: 
ArrayBuffer[_]) extends ReceivedBlock
    +private[streaming] case class IteratorBlock(iterator: Iterator[_]) extends 
ReceivedBlock
    +private[streaming] case class ByteBufferBlock(byteBuffer: ByteBuffer) 
extends ReceivedBlock
    +
    +
    +/** Trait that represents a class that handles the storage of blocks 
received by receiver */
    +private[streaming] trait ReceivedBlockHandler {
    +
    +  /** Store a received block with the given block id */
    +  def storeBlock(blockId: StreamBlockId, receivedBlock: ReceivedBlock): 
Option[AnyRef]
    --- End diff --
    
    Hm, another approach would be to have this return a type called 
`StoredBlockInfo` or something. And that could contain information about the 
BlockId and an optional file segment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to