Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/2937#discussion_r19453213
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/SortDataFormat.scala ---
@@ -27,33 +27,51 @@ import scala.reflect.ClassTag
* Example format: an array of numbers, where each element is also the key.
* See [[KVArraySortDataFormat]] for a more exciting format.
*
- * This trait extends Any to ensure it is universal (and thus compiled to
a Java interface).
+ * Declaring and instantiating multiple subclasses of this class would
prevent JIT inlining
--- End diff --
Maybe slight rephrasing of this to something like
```
Note: Declaring and instantiating multiple subclasses of this class would
prevent JIT inlining overridden methods and hence may decrease the shuffle
performance.
```
I just added "Note" since it's sort of a tangent and "may" since it may not
be noticeable for non computationally-intensive workloads.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
