Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2951#issuecomment-60536068
Unfortunately, this is going to fail the MiMa checks:
```
[info] spark-core: found 65 potential binary incompatibilities (filtered
293)
[error] * method
cartesian(org.apache.spark.api.java.JavaRDDLike)org.apache.spark.api.java.JavaPairRDD
in trait org.apache.spark.api.java.JavaRDDLike does not have a correspondent
in new version
[error] filter with:
ProblemFilters.exclude[MissingMethodProblem]("org.apache.spark.api.java.JavaRDDLike.cartesian")
[error] * method
reduce(org.apache.spark.api.java.function.Function2)java.lang.Object in trait
org.apache.spark.api.java.JavaRDDLike does not have a correspondent in new
version
[error] filter with:
ProblemFilters.exclude[MissingMethodProblem]("org.apache.spark.api.java.JavaRDDLike.reduce")
[...]
```
I guess this is because the fact that the trait contained default
implementations was part of its API contract from a Scala point of view. I
think that this is irrelevant from Java's perspective, though, so I'm going to
experiment with marking `Java*Like` as a developer APIs and purposely exposing
`AbstractJava*` as public abstract classes so that changes of their public APIs
will cause MiMa breakage.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
