Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2696#discussion_r19363966
--- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala ---
@@ -116,4 +94,60 @@ private[spark] object SparkUI {
def getUIPort(conf: SparkConf): Int = {
conf.getInt("spark.ui.port", SparkUI.DEFAULT_PORT)
}
+
+ def createLiveUI(
+ sc: SparkContext,
+ conf: SparkConf,
+ listenerBus: SparkListenerBus,
+ jobProgressListener: JobProgressListener,
+ securityManager: SecurityManager,
+ appName: String): SparkUI = {
+ create(Some(sc), conf, listenerBus, securityManager, appName,
+ jobProgressListener = Some(jobProgressListener))
+ }
+
+ def createHistoryUI(
+ conf: SparkConf,
+ listenerBus: ReplayListenerBus,
--- End diff --
If you want to look at code:
https://github.com/vanzin/spark/blob/yarn-timeline/yarn/timeline/src/main/scala/org/apache/spark/deploy/yarn/timeline/YarnTimelineProvider.scala#L107
Short story: ReplayListenerBus is very tightly coupled with
EventLoggingListener and the idea that events come from a file in a specific
format. So unless you're reading a file created by EventLoggingListener, it's
not very useful at the moment.
But my main point is that the Spark UI code does not depend on that
instance being a ReplayListenerBus, so I don't see the point in making the API
enforce that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
