Github user kayousterhout commented on the pull request:
https://github.com/apache/spark/pull/2867#issuecomment-60443288
I can add the tooltips in an hour or so -- was waiting to modify this to
hear if there were more review comments, but it sounds like there are not!
Will post an updated version in a bit. Thanks for the update Josh!
On Fri, Oct 24, 2014 at 1:14 PM, Josh Rosen <[email protected]>
wrote:
> I've decided to hold off on introducing my table-builder abstraction,
> since it's kind of leaky because there are corner-cases that it doesn't
> handle cleanly. Therefore, this shouldn't block on that. It would be great
> to try to get this merged so that it can unblock your other metrics patch.
>
> Regarding tooptips: I agree with Andrew that inline descriptions of the
> metrics might look a little cluttered, so hover tooltips would be a nice
> addition. This is a net improvement over what we have now, though, so I
> suppose we could wait until later to add those tooltips.
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/2867#issuecomment-60442759>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
