Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2899#discussion_r19288406
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala
---
@@ -18,6 +18,7 @@
package org.apache.spark.sql.hive.execution
import scala.collection.JavaConversions._
+import scala.collection.Map
--- End diff --
I think it's better to use `scala.collection.Map` explicitly in the code
below, and add comment to explain. Another reason that makes putting this line
here dangerous is that imports can be easily reorganized automatically by IDEs,
which are sometimes not smart enough.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
