Github user ScrapCodes commented on a diff in the pull request:
https://github.com/apache/spark/pull/771#discussion_r19197267
--- Diff:
core/src/main/scala/org/apache/spark/deploy/master/PersistenceEngine.scala ---
@@ -26,35 +30,58 @@ package org.apache.spark.deploy.master
* we might not have yet deleted apps or workers that finished (so their
liveness must be verified
* during recovery).
*/
-private[spark] trait PersistenceEngine {
- def addApplication(app: ApplicationInfo)
+@DeveloperApi
+trait PersistenceEngine {
+
+ def persist(name: String, obj: Object)
+
+ def unpersist(name: String)
+
+ def read[T: ClassTag](name: String): Seq[T]
--- End diff --
I kept ClassTag so that if someone extends this method he can control how
read behaves based on Whether its ApplicationInfo/WorkerInfo/ etc... . Such a
thing would be impossible otherwise - since we are making other methods as
final. I am not sure if that would be absolutely necessary. Thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
