Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2471#discussion_r19179186
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -29,14 +31,36 @@ import org.apache.spark.scheduler._
import org.apache.spark.ui.SparkUI
import org.apache.spark.util.Utils
+import com.google.common.util.concurrent.ThreadFactoryBuilder
+
private[history] class FsHistoryProvider(conf: SparkConf) extends
ApplicationHistoryProvider
with Logging {
private val NOT_STARTED = "<Not Started>"
+ // One day
+ private val DEFAULT_SPARK_HISTORY_FS_CLEANER_INTERVAL_S = Duration(1,
TimeUnit.DAYS).toSeconds
+
+ // One week
+ private val DEFAULT_SPARK_HISTORY_FS_MAXAGE_S = Duration(7,
TimeUnit.DAYS).toSeconds
+
+ private def warnUpdateInterval(value: String): String = {
+ logWarning("Using spark.history.fs.updateInterval to set interval " +
+ "between each check for event log updates is deprecated, " +
+ "please use spark.history.fs.update.interval.seconds instead.")
+ value
+ }
+
// Interval between each check for event log updates
- private val UPDATE_INTERVAL_MS =
conf.getInt("spark.history.fs.updateInterval",
- conf.getInt("spark.history.updateInterval", 10)) * 1000
+ private val UPDATE_INTERVAL_MS =
conf.getOption("spark.history.fs.update.interval.seconds")
+
.orElse(conf.getOption("spark.history.fs.updateInterval").map(warnUpdateInterval))
+ .orElse(conf.getOption("spark.history.updateInterval"))
--- End diff --
nit: could warn here too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
