Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1567#issuecomment-59969282
Yeah, please do post a design doc. Also, sorry for not reviewing this
earlier. This will be a good feature to have.
I did a quick pass and I have two high level concerns (though I did not
look in much detail):
- The creation of bit vectors seems like a very implementation focused
physical concern. I'm curious if this could be restricted to the actual
physical operator.
- Adding a new type of attribute reference for virtual columns might be a
lot of overhead. Is this really necessary?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
