Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2696#discussion_r18855660
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -229,10 +233,26 @@ class SparkContext(config: SparkConf) extends Logging 
{
       private[spark] val metadataCleaner =
         new MetadataCleaner(MetadataCleanerType.SPARK_CONTEXT, this.cleanup, 
conf)
     
    -  // Initialize the Spark UI, registering all associated listeners
    +
    +  private[spark] val environmentListener = new EnvironmentListener
    --- End diff --
    
    Since you're touching this, let me suggest something different, since I'm 
not sure I like the approach you took very much. 
    
    How about making SparkUI a listener itself, that just delegates events to 
its internal listeners?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to