GitHub user sarutak opened a pull request:
https://github.com/apache/spark/pull/2761
[SPARK-3854] Scala style: require spaces before `{`
This PR is a solution proposal of SPARK-3854.
Following is quoted from SPARK-3854:
We should require spaces before opening curly braces. This isn't in the
style guide, but it probably should be:
// Correct:
if (true) {
println("Wow!")
}
// Incorrect:
if (true){
println("Wow!")
}
See https://github.com/apache/spark/pull/1658#discussion-diff-18611791 for
an example "in the wild."
git grep "){" shows only a few occurrences of this style.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sarutak/spark SPARK-3854
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/2761.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2761
----
commit 8131d284dd7a718dd4fbbf31d3cadf6a3195680a
Author: Kousuke Saruta <[email protected]>
Date: 2014-10-09T10:21:26Z
Added SparkSpaceBeforeLeftBraceChecker to check spaces before "{"
commit 69716ec48b4f05b4ce705c32c44f6d2b6cff8ebc
Author: Kousuke Saruta <[email protected]>
Date: 2014-10-11T04:08:04Z
Merge branch 'master' of git://git.apache.org/spark into SPARK-3854
commit 4014be060ddf09de2e974a716d3763050a8597bd
Author: Kousuke Saruta <[email protected]>
Date: 2014-10-11T05:44:13Z
Fixed styles
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
