Github user cloud-fan commented on the pull request:

    https://github.com/apache/spark/pull/2543#issuecomment-58600998
  
    @marmbrus As commented before, I think we should handle `GetItem` and 
`GetField` differently even they are very similar. For `GetItem`, we need 
calculate the `ordinal` by evaluating an expression, for `GetField`, we can 
calculate the `ordinal` by searching the corrected `StrcutField` according to 
`fieldName` which I think should be done in analyze phase. It may be better to 
put `StructFiled` into `GetFiled` but not a simple `fieldName`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to