Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/1222#issuecomment-58236925
About the simplification you allude to, my goal was to remove coupling. I
felt like the existing classes were too closely coupled. Now,
EventLoggingListener only deals with two things: writing the event logging, and
opening it (handling all the compression and everything else that can be
encoded in the header). ReplayListenerBus only deals with a single thing:
reading events from an input stream, it doesn't matter where it comes from. And
backwards compatibility of the log format is handled in the only place where it
matters (the file system backend of the history server).
The version is not used, but then, it existed before and was not used
either. I fell like it's important to keep it though. It could be a separate
type that encapsulates both the stream and the version, or the current code
which uses a tuple, but I don't like the idea of just getting rid of the
version.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
