Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/1222#issuecomment-58139205
Hey @vanzin I took a pass at this. I think the high-level approach is good,
but I'd like to keep the event logs in a human readable format, as opposed to
encoding the header as bytes (if I'm understanding it correctly). For example,
something like the following would be good:
```
Spark version = 1.1.0
Compression codec = org.apache.spark.io.LZFCompressionCodec
...
=== HEADER END ===
// Json
```
Another comment I have is that I find the signature `(input stream, spark
version)` fairly awkward. Also I don't see a place where we ever consume the
version anyway, so I think you can just drop it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
