Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/789#discussion_r18176335
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
    @@ -140,6 +141,20 @@ class SparkConf(loadDefaults: Boolean) extends 
Cloneable with Logging {
         this
       }
     
    +  /**
    +   * Use Kryo serialization and register the given set of classes with 
Kryo.
    +   * If called multiple times, this will append the classes from all calls 
together.
    +   */
    +  def registerKryoClasses(classes: Array[Class[_ <: Any]]): SparkConf = {
    --- End diff --
    
    To make it more consistent with other configs - should this be something 
like `setKryoClasses`? Also can we have it take the more general `Seq` type 
instead of `Array[]`? Finally, is it not okay to do `Seq[Class[_]]`? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to