Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2485#discussion_r18049458
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientArguments.scala
---
@@ -39,15 +39,19 @@ private[spark] class ClientArguments(args:
Array[String], sparkConf: SparkConf)
var appName: String = "Spark"
var priority = 0
+ parseArgs(args.toList)
+ loadEnvironmentArgs()
+
// Additional memory to allocate to containers
// For now, use driver's memory overhead as our AM container's memory
overhead
- val amMemoryOverhead = sparkConf.getInt(
- "spark.yarn.driver.memoryOverhead",
YarnSparkHadoopUtil.DEFAULT_MEMORY_OVERHEAD)
- val executorMemoryOverhead = sparkConf.getInt(
- "spark.yarn.executor.memoryOverhead",
YarnSparkHadoopUtil.DEFAULT_MEMORY_OVERHEAD)
+ val amMemoryOverhead =
sparkConf.getInt("spark.yarn.driver.memoryOverhead",
+ math.max((YarnSparkHadoopUtil.MEMORY_OVERHEAD_FACTOR *
amMemory).toInt,
+ YarnSparkHadoopUtil.MEMORY_OVERHEAD_MIN))
+
+ val executorMemoryOverhead =
sparkConf.getInt("spark.yarn.executor.memoryOverhead",
+ math.max((YarnSparkHadoopUtil.MEMORY_OVERHEAD_FACTOR *
executorMemory).toInt,
+ YarnSparkHadoopUtil.MEMORY_OVERHEAD_MIN))
--- End diff --
Hm, these will be much easier to read if you just import
`YarnSparkHadoopUtil._` up top
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
