Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2432#discussion_r18007241
  
    --- Diff: 
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
 ---
    @@ -106,7 +106,8 @@ private[spark] object CoarseGrainedExecutorBackend 
extends Logging {
           executorId: String,
           hostname: String,
           cores: Int,
    -      workerUrl: Option[String]) {
    +      workerUrl: Option[String],
    +      appId: String) {
    --- End diff --
    
    Really minor nit, but do you mind swapping the order of `appId` and 
`workerUrl` so that the order of the command-line options matches the order of 
the constructor arguments?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to