Github user rnowling commented on the pull request:
https://github.com/apache/spark/pull/2494#issuecomment-56464302
@Ishiihara Thanks for pointing out the style check -- I found and fixed the
style error in IDF.scala.
Thanks for mentioning options for the mimimumOccurence members. I decided
to add the val keyword over adding a setter. Earlier, I had considered several
approaches including making it an optional parameter and adding a Scala-style
setter, however I found that neither provided clean Java interoperability. As
a result, I settled on the overloaded constructor approach, which also matches
the emphasis on immutability within Scala better. Since creating IDF's is
inexpensive, I don't think performance will be an issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
