Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/2425#discussion_r17822775
--- Diff: core/src/main/scala/org/apache/spark/scheduler/Task.scala ---
@@ -45,7 +45,8 @@ import org.apache.spark.util.Utils
private[spark] abstract class Task[T](val stageId: Int, var partitionId:
Int) extends Serializable {
final def run(attemptId: Long): T = {
- context = new TaskContext(stageId, partitionId, attemptId,
runningLocally = false)
+ context = new TaskContext(stageId, partitionId, attemptId, false)
--- End diff --
any reason to drop the naming for `runningLocally`? the correct style is to
name all optional paremeters.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
