Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1853#discussion_r16008222
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
    @@ -30,6 +30,7 @@ private[spark] object SQLConf {
       val SHUFFLE_PARTITIONS = "spark.sql.shuffle.partitions"
       val CODEGEN_ENABLED = "spark.sql.codegen"
       val DIALECT = "spark.sql.dialect"
    +  val INCREMENTAL_COLLECT_ENABLED = "spark.sql.incrementalCollect"
    --- End diff --
    
    Lets put this under `spark.sql.thriftServer...`.  Also, what do you think 
about putting it in with the thrift server instead?  It seems kinda odd to me 
to be configuring things for the thrift server in a place where the code 
doesn't even exist.  This is how we do things for Hive now (see `HiveContext` 
in #1819 ).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to