Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/1854#issuecomment-51599157
@YanTangZhai I'm not sure I wrote that clearly. I should say that the
behavior you have here could be correct if it's fine that a call to remove some
elements merely removes some stuff from `stages` whether they're active or not.
But then, I wonder about this problem: here, if I remove 5 elements, and remove
all of the 10s from `stages`, and of course nothing from `stageIdToData` since
they're active, then will I ever remove 10 from `stageIdToData` when it's not
active? because it's already disappeared from `stages` earlier when 10 was
active. I think that might be a problem but not sure. Anyway that's another
motivation for not removing anything from `stages` unless it is known to be
inactive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
