Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/13135#discussion_r63374755
--- Diff: examples/src/main/python/ml/simple_params_example.py ---
@@ -70,18 +71,18 @@
# We may alternatively specify parameters using a parameter map.
# paramMap overrides all lr parameters set earlier.
- paramMap = {lr.maxIter: 20, lr.thresholds: [0.45, 0.55],
lr.probabilityCol: "myProbability"}
+ paramMap = {lr.maxIter: 20, lr.thresholds: [0.5, 0.5],
lr.probabilityCol: "myProbability"}
--- End diff --
I think it's not necessary to update here. If users explicitly set
```thresholds``` then ```threshold``` will be cleared and takes no effect, and
vice verse. In this example, users explicitly set ```thresholds``` to ```[0.45,
0.55]``` is okey and will not throw any exception.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
