GitHub user BryanCutler opened a pull request:
https://github.com/apache/spark/pull/12304
[SPARK-14472][PYSPARK][ML] Cleanup ML JavaWrapper and related class
hierarchy
Currently, JavaWrapper is only a wrapper class for pipeline classes that
have Params and JavaCallable is a separate mixin that provides methods to make
Java calls. This change simplifies the class structure and to define the Java
wrapper in a plain base class along with methods to make Java calls. Also,
renames Java wrapper classes to better reflect their purpose.
Ran existing Python ml tests and generated documentation to test this
change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BryanCutler/spark
pyspark-cleanup-JavaWrapper-SPARK-14472
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12304.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12304
----
commit b8d022a577d20ac213fb263f973172c23d2f2ee7
Author: Bryan Cutler <[email protected]>
Date: 2016-04-11T16:12:15Z
[SPARK-14472] Made JavaCallable a base class to JavaWrapper to define
_java_obj and creating Java objects
commit c95ba2782c002c531b3d46cb4e770c5ace52215d
Author: Bryan Cutler <[email protected]>
Date: 2016-04-11T18:33:51Z
Renamed classes to better reflect purpose, JavaWrapper to JavaWrapperParams
and JavaCallable to JavaWrapper
commit c1d41c7de25ba798abd4da5b342df15eede442b5
Author: Bryan Cutler <[email protected]>
Date: 2016-04-11T18:37:23Z
Made alternate constructor for JavaWrapper private so doesn't appear in docs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
