Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12105#discussion_r58745694
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -416,11 +419,17 @@ abstract class UnixTime extends BinaryExpression with
ExpectsInputTypes {
}
case StringType =>
val sdf = classOf[SimpleDateFormat].getName
+ val formatter = ctx.freshName("sdf")
+ ctx.addMutableState(sdf, formatter, s"""$formatter = null;""")
nullSafeCodeGen(ctx, ev, (string, format) => {
s"""
try {
+ if ($formatter == null ||
+ !$formatter.toPattern().equals("$format.toString()")) {
--- End diff --
This optimization seems useless to me too, I'd like to not have it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
