Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/12047#discussion_r58745638
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRelation.scala
---
@@ -306,6 +315,10 @@ private[sql] class DefaultSource
SQLConf.PARQUET_INT96_AS_TIMESTAMP.key,
sqlContext.conf.getConf(SQLConf.PARQUET_INT96_AS_TIMESTAMP))
+ // Whole stage codegen (PhysicalRDD) is able to deal with batches
directly
+ parquetConf.setBoolean(ParquetRelation.RETURNING_BATCH,
+ supportBatch(sqlContext, StructType(partitionSchema.fields ++
dataSchema.fields)))
--- End diff --
In general, I'd prefer if all new code passes options explicitly to the
closure instead of through the conf.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
