Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12183#discussion_r58631042
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -84,15 +84,21 @@ class SessionCatalog(
//
----------------------------------------------------------------------------
def createDatabase(dbDefinition: CatalogDatabase, ignoreIfExists:
Boolean): Unit = {
- externalCatalog.createDatabase(dbDefinition, ignoreIfExists)
+ if (!databaseExists(dbDefinition.name)) {
+ externalCatalog.createDatabase(dbDefinition, ignoreIfExists)
+ }
}
def dropDatabase(db: String, ignoreIfNotExists: Boolean, cascade:
Boolean): Unit = {
- externalCatalog.dropDatabase(db, ignoreIfNotExists, cascade)
+ if (databaseExists(db)) {
+ externalCatalog.dropDatabase(db, ignoreIfNotExists, cascade)
+ }
--- End diff --
This is now wrong. We used to pass the flag `ignoreIfNotExists` to the
external catalog, which will handle the exception throwing. Now we'll ignore
this flag if the database doesn't exist.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
