Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12020#discussion_r58596688
  
    --- Diff: python/pyspark/ml/wrapper.py ---
    @@ -88,6 +99,18 @@ def _transfer_params_from_java(self):
                         value = _java2py(sc, 
self._java_obj.getOrDefault(java_param))
                         self._paramMap[param] = value
     
    +    def _transfer_extra_params_from_java(self, extra):
    --- End diff --
    
    Same here: Rename to _transfer_param_map_from_java, and rename "extra" to 
"java_param_map"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to