Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12020#discussion_r58421680
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -200,6 +204,11 @@ class CrossValidatorModel private[ml] (
@Since("1.5.0") val avgMetrics: Array[Double])
extends Model[CrossValidatorModel] with CrossValidatorParams with
MLWritable {
+ /** A Java/Python-friendly auxiliary constructor. */
+ private[ml] def this(uid: String, bestModel: Model[_], avgMetrics:
ju.List[Double]) = {
--- End diff --
Similar comment to the one bellow, if this is intended for both Java and
Python then we probably don't want it to be private ml scope - but it seems
like the intended use of this is Python and this might be better suited to
PythonMLLibAPI.scala
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
