Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11805#discussion_r58129991
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/rdd/WriteAheadLogBackedBlockRDD.scala
---
@@ -162,7 +162,8 @@ class WriteAheadLogBackedBlockRDD[T: ClassTag](
logDebug(s"Stored partition data of $this into block manager with
level $storageLevel")
dataRead.rewind()
}
- serializerManager.dataDeserialize(blockId, new
ChunkedByteBuffer(dataRead))
+ serializerManager
+ .dataDeserializeStream(blockId, new
ChunkedByteBuffer(dataRead).toInputStream())
--- End diff --
toInputStream() takes an optional parameter for controlling whether buffers
are released upon the stream being completely read. Adding an overload kind of
masks this option. The one line of extra duplication didn't seem like a big
deal to me so I didn't want to add more overloads.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
