Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11995#discussion_r57605112
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
 ---
    @@ -518,8 +543,8 @@ private[sql] object Expand {
     case class Expand(
         projections: Seq[Seq[Expression]],
         output: Seq[Attribute],
    -    child: LogicalPlan) extends UnaryNode {
    -
    +    child: LogicalPlan,
    +    constraintsBase: Seq[Expression]) extends UnaryNode {
    --- End diff --
    
    This parameter is not documented.
    
    Also, this operator is kind of violating the style of logical operators.  
The goal here is for query nodes to be correct by construction (i.e. figure out 
things like constraints by inspecting themselves and their children).
    
    It would be great if we could move constraint pruning logic into `Expand`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to