Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1165#discussion_r15331051
--- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala ---
@@ -225,9 +374,18 @@ private class MemoryStore(blockManager: BlockManager,
maxMemory: Long)
return ResultWithDroppedBlocks(success = false, droppedBlocks)
}
- if (maxMemory - currentMemory < space) {
+ // Take into account the amount of memory currently occupied by
unrolling blocks
+ val freeSpace =
+ if (!unrolling) {
+ val unrollMemoryMap = SparkEnv.get.unrollMemoryMap
+ unrollMemoryMap.synchronized { freeMemory -
unrollMemoryMap.values.sum }
--- End diff --
If you remove the separate locking on unrollMemoryMap you can get rid of
the synchronized here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
