Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11160#discussion_r52825264
--- Diff: project/SparkBuild.scala ---
@@ -167,8 +167,8 @@ object SparkBuild extends PomBuild {
publishLocalBoth <<= Seq(publishLocal in MavenCompile,
publishLocal).dependOn,
javacOptions in (Compile, doc) ++= {
- val Array(major, minor, _) =
System.getProperty("java.version").split("\\.", 3)
- if (major.toInt >= 1 && minor.toInt >= 8) Seq("-Xdoclint:all",
"-Xdoclint:-missing") else Seq.empty
+ val version = System.getProperty("java.version")
+ if (version >= "1.8.0") Seq("-Xdoclint:all", "-Xdoclint:-missing")
else Seq.empty
--- End diff --
Hm, this only happens to work for 1.8 vs 9. This seems hacky compared to
just emulating the simple logic you wrote above -- why not that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
