Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1502#discussion_r15214488
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala
---
@@ -252,7 +251,7 @@ class ExternalAppendOnlyMap[K, V, C](
if (it.hasNext) {
var kc = it.next()
kcPairs += kc
- val minHash = getKeyHashCode(kc)
+ val minHash = hashKey(kc)
--- End diff --
Just curious, is this more efficient than calling
ExternalAppendOnlyMap.hash directly as we did before? It was kind of weird that
we were doing it in an inner class, maybe it created another pointer
derefernece.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
