Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10319#discussion_r49696555
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -364,7 +380,23 @@ private[spark] class CoarseMesosSchedulerBackend(
}
override def stop() {
- super.stop()
+ // Make sure we're not launching tasks during shutdown
+ stateLock.synchronized {
+ if (stopCalled) {
+ logWarning("Stop called multiple times, ignoring")
+ return
+ }
+ stopCalled = true
+ super.stop()
+ }
+ // Wait for finish
+ val stopwatch = new Stopwatch()
+ stopwatch.start()
+ // Eventually consistent slaveIdsWithExecutors
--- End diff --
Not sure if this comments says much, can you perhaps add some comments that
slaveIdsWithExecutors will be empty once we receive task termination status
updates from all tasks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
