Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1241#discussion_r14696031
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/HashShuffleBlockManager.scala
---
@@ -59,8 +64,10 @@ private[spark] trait ShuffleWriterGroup {
* files within a ShuffleFileGroups associated with the block's reducer.
*/
private[spark]
-class ShuffleBlockManager(blockManager: BlockManager) extends Logging {
- def conf = blockManager.conf
+class HashShuffleBlockManager(conf: SparkConf)
--- End diff --
One thing about this naming is that the block manager technically isn't
specific to hashing. For example, we can still do sort-based shuffle using this
block manager (although that's unlikely to happen).
@aarondav any thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
