Github user gatorsmile commented on the pull request:

    https://github.com/apache/spark/pull/9806#issuecomment-157749632
  
    Your code looks pretty clean to me. Let me share my test cases this PR 
failed. 
    
    ```
     test("joinWith tuple - self join 1") {
       val ds = Seq(("a", 1), ("b", 2)).toDS()
       ds.joinWith(ds, $"_2" === $"_2").collect()
     }
    
      test("joinWith tuple - self join 2") {
        val ds1 = Seq(("a", 1), ("b", 2)).toDS()
        val ds2 = Seq(("a", 1), ("b", 2)).toDS().as("a")
        ds1.joinWith(ds2, $"_2" === $"a._2").collect()
      }
    ```
    
    Do you want me to send me a PR? Or you will fix them?
    
    Thank you! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to