Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7888#discussion_r45012825
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
 ---
    @@ -442,7 +452,7 @@ class CoarseGrainedSchedulerBackend(scheduler: 
TaskSchedulerImpl, val rpcEnv: Rp
           numPendingExecutors += knownExecutors.size
         }
     
    -    doKillExecutors(executorsToKill)
    +    (force || !executorsToKill.isEmpty) && doKillExecutors(executorsToKill)
    --- End diff --
    
    Either way is fine. If you can get the tests passing without too much hack 
then we can do it; when I tried that myself it was failing in a way that was 
hard to reason about.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to